Primary Functionality #3

Merged

parabitdev merged 10 commits from parabit/proof-of-concept into master 2026-04-29 22:36:30 +00:00

Conversation 1 Commits 10 Files changed 46 +5917 -174

parabitdev commented 2026-02-16 17:19:18 +00:00 (Migrated from github.com)

Copy link

Started as a proof of concept, but with the systems all working correctly, I think it is worth merging this and then working on the frontend/design to release it as a real product.

Started as a proof of concept, but with the systems all working correctly, I think it is worth merging this and then working on the frontend/design to release it as a real product.  

Screenshot from 2026-04-29 14-20-43.png

72 KiB

Screenshot from 2026-04-29 14-20-55.png

69 KiB

parabit added 1 commit 2026-04-19 19:12:45 +00:00

theme and ci changes 0bb3bb7f21

parabit added 1 commit 2026-04-29 03:57:58 +00:00

first pass at collection-based swapping page d8a961428c

parabit added 1 commit 2026-04-29 19:41:58 +00:00

collection tooling 546a3228e0

parabit changed title from Implementation of PoC for Swap Market to Primary Functionality 2026-04-29 19:42:17 +00:00

paratoxic approved these changes 2026-04-29 22:35:07 +00:00

paratoxic left a comment

Owner

Copy link

I didn't look at all files in detail but overall it has a good structure and seems to work (ran some tests). A tip I would give along the way is to make the code more type safe. You have a lot of strings that will bite you in the ass down the road. For the ordinals stuff theres is also the ordinals crate and the ord crate that you can pull in to talk to the API (they have types already implemented). But overall LGTM

I didn't look at all files in detail but overall it has a good structure and seems to work (ran some tests). A tip I would give along the way is to make the code more type safe. You have a lot of strings that will bite you in the ass down the road. For the ordinals stuff theres is also the ordinals crate and the ord crate that you can pull in to talk to the API (they have types already implemented). But overall LGTM

parabit merged commit 59dd8b23da into master 2026-04-29 22:36:30 +00:00

parabit referenced this pull request from a commit 2026-04-29 22:36:32 +00:00

Primary Functionality (#3)

Sign in to join this conversation.

Reviewers

No reviewers

paratoxic

Labels

Clear labels   

bug

Something isn't working

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

bug

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

parasitepool/entangle!3

No description provided.