Add list orders by address endpoint #492

Merged
paratoxic merged 1 commit from orders-endpoint into master 2026-04-08 22:24:55 +00:00
Owner
No description provided.
Add list orders by address endpoint
Some checks failed
CI / ckpool (pull_request) Successful in 14s
CI / lint (pull_request) Successful in 1m9s
CI / test-linux (pull_request) Failing after 4m39s
6914c67e10
parabit approved these changes 2026-04-08 22:02:43 +00:00
parabit left a comment
Owner

LGTM

One nit

LGTM One nit
@ -81,6 +81,14 @@ impl TestRouter {
.await
}
pub(crate) async fn list_orders(&self, address: Option<&str>) -> reqwest::Result<Vec<u32>> {
Owner
- pub(crate) async fn list_orders(&self, address: Option<&str>) -> reqwest::Result<Vec<u32>> {
- 	let mut url = format!("{}/api/router/orders", self.api_endpoint());
- 	if let Some(addr) = address {
- 		url.push_str(&format!("?address={addr}"));
- 	}
- 	reqwest::Client::new().get(url).send().await?.json().await
- }
+ pub(crate) async fn list_orders(&self, address: Option<&str>) -> reqwest::Result<Vec<u32>> {
+     reqwest::Client::new()
+         .get(format!("{}/api/router/orders", self.api_endpoint()))
+         .query(&address.map(|addr| [("address", addr)]))
+         .send()
+         .await?
+         .json()
+         .await
+ }

Would it be cleaner do something like this with reqwest's query handler instead of manipulating strings directly?

```diff - pub(crate) async fn list_orders(&self, address: Option<&str>) -> reqwest::Result<Vec<u32>> { - let mut url = format!("{}/api/router/orders", self.api_endpoint()); - if let Some(addr) = address { - url.push_str(&format!("?address={addr}")); - } - reqwest::Client::new().get(url).send().await?.json().await - } + pub(crate) async fn list_orders(&self, address: Option<&str>) -> reqwest::Result<Vec<u32>> { + reqwest::Client::new() + .get(format!("{}/api/router/orders", self.api_endpoint())) + .query(&address.map(|addr| [("address", addr)])) + .send() + .await? + .json() + .await + } ``` Would it be cleaner do something like this with reqwest's query handler instead of manipulating strings directly?
paratoxic merged commit 33b8410eff into master 2026-04-08 22:24:55 +00:00
paratoxic deleted branch orders-endpoint 2026-04-08 22:24:55 +00:00
Sign in to join this conversation.
No description provided.