Fix potential statifier wedging #610

Merged

paratoxic merged 7 commits from fix-stratifer-wedge into master

2026-08-23 16:57:40 +00:00

paratoxic commented

2026-08-22 19:32:41 +00:00

Owner

Fixes this:

M1. Slow reader wedges session — `src/stratifier.rs`

ckpool: never writes to a client socket inline. A sender thread drains a
queue with non-blocking writes; a client blocked > 60 s is disconnected
(connector.c:730-777). Receive side: disconnect if buffer > 1024 B without
EOL (connector.c:494-573).

Design (para):

Per-connection writer task. Bounded mpsc::channel<String> (capacity ~64).
Writer drains frames into the existing
FramedWrite<OwnedWriteHalf, LinesCodec>.
send() becomes try_send. On full channel: close the connection
(ckpool's drop-on-stall equivalent). Precedent: send_event at
src/stratifier.rs:1231-1237.
Keep ordering: single writer task guarantees frame order.
Shutdown: writer owns the write half; serve() breaks -> drop sender ->
writer flushes and exits. Drop for Stratifier (:1240-1266) unchanged.
Error propagation: writer death closes the channel; tx.closed() in the
serve() select loop breaks the connection.
Reader already has LinesCodec::new_with_max_length(MAX_MESSAGE_SIZE) — no
change needed.

Constraint: request/response ordering is pinned by integration tests
(tests/pool.rs:220-264, bouncer test :1261-1460). Writer task preserves
it.

Fixes this: ## M1. Slow reader wedges session — `src/stratifier.rs` **ckpool:** never writes to a client socket inline. A sender thread drains a queue with non-blocking writes; a client blocked > 60 s is disconnected (`connector.c:730-777`). Receive side: disconnect if buffer > 1024 B without EOL (`connector.c:494-573`). **Design (para):** - Per-connection writer task. Bounded `mpsc::channel<String>` (capacity ~64). Writer drains frames into the existing `FramedWrite<OwnedWriteHalf, LinesCodec>`. - `send()` becomes `try_send`. On full channel: close the connection (ckpool's drop-on-stall equivalent). Precedent: `send_event` at `src/stratifier.rs:1231-1237`. - Keep ordering: single writer task guarantees frame order. - Shutdown: writer owns the write half; `serve()` breaks -> drop sender -> writer flushes and exits. `Drop for Stratifier` (`:1240-1266`) unchanged. - Error propagation: writer death closes the channel; `tx.closed()` in the `serve()` select loop breaks the connection. - Reader already has `LinesCodec::new_with_max_length(MAX_MESSAGE_SIZE)` — no change needed. **Constraint:** request/response ordering is pinned by integration tests (`tests/pool.rs:220-264`, bouncer test `:1261-1460`). Writer task preserves it.

paratoxic added 1 commit

2026-08-22 19:32:42 +00:00

Fix potential statifier wedging

CI / ckpool (pull_request) Successful in 39s

Details

CI / lint (pull_request) Successful in 3m45s

Details

CI / test-linux (pull_request) Has been cancelled

Details

13a1d3ea01

paratoxic added 1 commit

2026-08-22 19:39:47 +00:00