Improve key management/isolation #631
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
parasitepool/para!631
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "parabit/better-key-management"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I don't know if you're gonna do this in a follow up but this seems relevant:
Behavior regression: aggregator with admin-token only. aggregator.rs no longer sends the admin token when fetching /status; it relies on the default Authorization: Bearer <api_token> header set in Aggregator::init. But ServerConfig allows --admin-token without --api-token (the assertion at server.rs:235 only requires admin if api is set). An aggregator deployed with only an admin token will now get 401s from auth-enabled peers' /status and silently report blockheight: 0 (fetch errors are filtered out in blockheight). Previously this worked. Either send config.api_token().or(config.admin_token()) in Aggregator::init, or document that aggregators now require an api token. The updated tests (aggregator_blockheight_returns_minimum) only cover the both-tokens case, so this regression wouldn't be caught.
@ -0,0 +26,4 @@}let admin = parts.extensions.get::<BearerAuth>().is_none_or(|auth| {!auth.enabled()maybe auth.enabled() check should happen before database lookup?
LGTM