Add payments to orders #489
No reviewers
parabit
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
parasitepool/para!489
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "add-wallet"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add payments to ordersto WIP: Add payments to ordersWIP: Add payments to ordersto Add payments to ordersLGTM
We have some cleanup to do (tightening validation on CLI args, moving to double-conf instead of is_confirmed(), etc.), but when limited to the scope of this PR, this looks great.
@ -1373,3 +1414,3 @@#[test]fn router_vardiff_defaults() {let options = parse_router_options("para router --upstream bar@foo:1234");let options = parse_router_options("para router --descriptor foo");I would prefer the 'foo' placeholder be invalid due to type checking/validation, but that can follow in a cleanup PR.