Add hash price for orders #495
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
parasitepool/para!495
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "add-hashprice"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
LGTM
Two nits, no blockers
@ -98,2 +98,4 @@--tick-interval 1 \--hashprice 5000000 \--default-order tb1qft5p2uhsdcdc3l2ua4ap5qqfg4pjaqlp250x7us7a8qqhrxrxfsqaqh7jw.chameleon@127.0.0.1:42069 \--wallet-birthday 13000 \Is this just being used as a test value? It seems rather low for a real wallet.
@ -41,0 +43,4 @@value_parser = clap::value_parser!(u64).range(1..),help = "Price per petahash-day in sats.")]pub(crate) hash_price: u64,Would be better as a non-required field as it is reasonable that someone could want to use the router with only default-orders or with free reassignment of their hashrate.