parasitepool/para
2
0
Fork 0
Code Issues 8 Pull requests 2 Projects Releases 1 Activity Actions

Improve block found notifications #524

Merged
parabit merged 2 commits from parabit/notification-refinement into master 2026-04-17 19:50:44 +00:00
Conversation 1 Commits 2 Files changed 6 +348 -32
parabit commented 2026-04-17 19:18:36 +00:00
Owner
Copy link
  • Add satsheet to notifications
  • Add testing capability to notifications/sync using deadbeefdeadbeef prefix (real blocks are 000... prefixed so this can't collide with real blocks)
  • Tighten constraints on testing db
    • BUG: we had 66 hex digit block hashes in our tests previously, trimmed to 32-bytes (dropping two hex digits)
  • Add e2e testing around block find/notification
- [x] Add satsheet to notifications - [x] Add testing capability to notifications/sync using `deadbeefdeadbeef` prefix (real blocks are `000...` prefixed so this can't collide with real blocks) - [x] Tighten constraints on testing db - [x] BUG: we had 66 hex digit block hashes in our tests previously, trimmed to 32-bytes (dropping two hex digits) - [x] Add e2e testing around block find/notification
e2e tests and satsheet attachment
Some checks failed
CI / ckpool (pull_request) Successful in 58s
Details
CI / lint (pull_request) Successful in 3m33s
Details
CI / test-linux (pull_request) Failing after 7m32s
Details
6862fd4f2d
paratoxic approved these changes 2026-04-17 19:27:23 +00:00
paratoxic left a comment
Owner
Copy link

LGTM

LGTM
make test ignored
All checks were successful
CI / ckpool (pull_request) Successful in 18s
Details
CI / lint (pull_request) Successful in 1m58s
Details
CI / test-linux (pull_request) Successful in 5m28s
Details
17233a303c
parabit merged commit fce79ec5ea into master 2026-04-17 19:50:44 +00:00
parabit deleted branch parabit/notification-refinement 2026-04-17 19:50:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
paratoxic
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
parasitepool/para!524
No description provided.