WIP: Enforce enonce1 uniqueness for small enonces #534
No reviewers
parabit
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
parasitepool/para!534
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "implement-max-clients"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #518
Enforce enonce1 uniquenessto Enforce enonce1 uniqueness for small enoncesLGTM
Took me a minute to understand why the test showed 256 max clients, could maybe use a comment there?
@ -1,9 +1,12 @@use super::*;const MAX_TRACKED_CLIENTS: usize = 1 << 16;That's a big number! Also, isn't this just u16::max?
@ -76,2 +125,4 @@}fn proxy_allocator(extension_size: usize) -> EnonceAllocator {let upstream_enonce1 = Extranonce::from_bytes(&[0xde, 0xad, 0xbe, 0xef]);Unrelated to PR, it may be nice to have a helper function on Extranonce that lets you pass these as a hex string "deadbeef" and it just handles the parse with radix 16.
Enforce enonce1 uniqueness for small enoncesto WIP: Enforce enonce1 uniqueness for small enoncesView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.