WIP: Add refinery leaderboards #288

Draft
paratoxic wants to merge 5 commits from refinery-leaderboards into master
Owner
No description provided.
Add refinery leaderboards
All checks were successful
CI / test (pull_request) Successful in 2m33s
1fce393078
Consolidate
All checks were successful
CI / test (pull_request) Successful in 2m25s
657e74dc98
Improve
All checks were successful
CI / test (pull_request) Successful in 2m23s
d7690f920b
Fix
All checks were successful
CI / test (pull_request) Successful in 2m10s
847fa0fc82
parabit approved these changes 2026-11-11 18:09:01 +00:00
parabit left a comment

LGTM

LGTM
@ -0,0 +53,4 @@
order({ id: 5, username: 'garbage.worker', delivered_hash_days: 8e15 }),
];
function makeRequest(client: string, query = ''): NextRequest {
Owner

makeRequest is async. The client string can instead be constructed from a counter (for final octet).

Additionally, it should do so on one of the TEST-NET-N ranges:
192.0.2.0/24
198.51.100.0/24
203.0.113.0/24

The current range you are using is internal ips and some software may treat these differently as it is often marked as 'private' or 'internal' by services/libraries that are address aware.

makeRequest is async. The client string can instead be constructed from a counter (for final octet). Additionally, it should do so on one of the TEST-NET-N ranges: 192.0.2.0/24 198.51.100.0/24 203.0.113.0/24 The current range you are using is internal ips and some software may treat these differently as it is often marked as 'private' or 'internal' by services/libraries that are address aware.
@ -93,0 +117,4 @@
return {
created_at: createdAt,
last_share: shares.length > 0 ? Math.max(...shares) : null,
Owner

We don't use a sentinel value in last_share on either side right? If so this sort could be unreliable.

We don't use a sentinel value in last_share on either side right? If so this sort could be unreliable.
paratoxic changed title from Add refinery leaderboards to WIP: Add refinery leaderboards 2026-11-16 20:49:56 +00:00
Some checks failed
CI / test (pull_request) Failing after 2m19s
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin refinery-leaderboards:refinery-leaderboards
git switch refinery-leaderboards

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff refinery-leaderboards
git switch refinery-leaderboards
git rebase master
git switch master
git merge --ff-only refinery-leaderboards
git switch refinery-leaderboards
git rebase master
git switch master
git merge --no-ff refinery-leaderboards
git switch master
git merge --squash refinery-leaderboards
git switch master
git merge --ff-only refinery-leaderboards
git switch master
git merge refinery-leaderboards
git push origin master
Sign in to join this conversation.
No description provided.